NEEDS ATTENTION: Setting up Github Container Package releases

caprover / deploy-from-github

Apache License 2.0

58 stars 18 forks source link

NEEDS ATTENTION: Setting up Github Container Package releases #3

Closed maietta closed 2 years ago

maietta commented 2 years ago

Glad I could contribute with all the suggested changes. Much thanks for accepting the project.

I've been working to try and solve why the package "deploy-from-github" hasn't been showing up. I think I know why, but I am not 100% sure. It's been hell to try and track down just exactly what is going on.

It's been so long since I needed to do anything with Github Container Registry that I had completely forgotten this important step to getting this Github Action usable for the general public.

I am submitting another PR as well, with a simpler workflow to create and push docker images to the Github Registry.

maietta commented 2 years ago

So basically @githubsaturn, you'll need to visit your organization's main page and find the "Packages" tab.

Once there, you'll see the deploy-from-github container package.

You need to do two things:

Possibly required to attach the container package to the repository.
Allow the container to be edited via Github Actions with Role:Write instead of Role:Read.

Once this is one, I think the package will finally be public but I'm almost certain it exists already.

githubsaturn commented 2 years ago

Sounds good. Just left a minor comment on your PR.

maietta commented 2 years ago

Good point and now the ball is back in your court.

maietta commented 2 years ago

Thanks, @githubsaturn!

I hope to get better with this Github Workflows and Actions metadata stuff as I have many projects that will need better CI/CD tooling.

Your help in all this is greatly appreciated.