search

caprover / netdata-docker

Just a wrapper around NetData container to provide env var settings for some params
1 stars 7 forks source link

Upgrade Netdata to the latest version #3

Closed rklos closed 2 years ago

rklos commented 2 years ago

An attempt to upgrade Netdata to the latest version. I tried to make as few changes as possible. As @githubsaturn said, since version 1.12.0, Netdata is collecting anonymous statistics. As recommended, telemetry was disabled at the installation process.

I tested it out for a while with Burp Suite, and no requests were made to netdata.cloud. However, please test it for yourself, especially the integration with caprover (it works, but I don't know how to check if I broke something).

Closes: https://github.com/caprover/netdata-docker/issues/2

githubsaturn commented 2 years ago

Perfect! Have you also tested the environmental variables? Testing one or two is enough to make sure that they still work.

Testing with CapRover is super simple actually! If you have the image built, you can simply override the image that CapRover uses:

nano /captain/data/config-override.json

## Override netdata image:
{
 "netDataImageName":"yourdockeruser/yourdockerimage:yourtag"
}
rklos commented 2 years ago

I have tested caprover integration based on your example. I have also tested telegram notifications (through caprover frontend) and it works!

githubsaturn commented 2 years ago

Amazing! Thanks!