capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.
http://www.capstone-engine.org
7.61k stars 1.56k forks source link

Add test with ASAN enabled. #2313

Closed Rot127 closed 5 months ago

Rot127 commented 7 months ago

Your checklist for this pull request

Detailed description

Add ASAN builds

It does a few things

Test plan

CI green (or, if everything fails horribly, mark it optoinal for now)

Closing issues

closes https://github.com/capstone-engine/capstone/issues/2368

XVilka commented 5 months ago

@Rot127 please rebase this one, it should fix the redness.

Rot127 commented 5 months ago

I remove the DIET changes again. Build is still fixed. They are too complicated to fix for now and not testable. Because we can only test the details and decoding by printing it first, all the test cases of us fail. So I think if we fix it it should be done once in a separated PR. Also we can reduce the binary size even more.

XVilka commented 5 months ago

@kabeor please take a look and lets merge this quickly, so new PRs will not introduce ASAN warnings.

XVilka commented 5 months ago

@kabeor @aquynh

XVilka commented 5 months ago

@kabeor while you are online, could you please merge also this one and the LoongArch PRs?

kabeor commented 5 months ago

Great, thanks!