search

capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.
http://www.capstone-engine.org
7.61k stars 1.56k forks source link

[next] Fix #2079: Add missing 1 immediate to `rcl` #2330

Closed Rot127 closed 6 months ago

Rot127 commented 6 months ago

Your checklist for this pull request

Detailed description

Companion PR to https://github.com/capstone-engine/capstone/pull/2329. Simply because x86 won't be updated to AS, so the fix should also be in v6.

Test plan

Add to issues.cs

./cstool -d x32 0xd1,0x10
 0  d1 10                                            rcl    dword ptr [eax]
    ID: 615 (rcl)
    Prefix:0x00 0x00 0x00 0x00 
    Opcode:0xd1 0x00 0x00 0x00 
    rex: 0x0
    addr_size: 4
    modrm: 0x10
    disp: 0x0
    sib: 0x0
    imm_count: 1
        imms[1]: 0x1
    op_count: 2
        operands[0].type: MEM
            operands[0].mem.base: REG = eax
        operands[0].size: 4
        operands[0].access: READ
        operands[1].type: IMM = 0x1
        operands[1].size: 0
        operands[1].access: READ
    Registers read: eax
    Registers modified: eflags
    EFLAGS: MOD_CF UNDEF_OF

Closing issues

...