Closed numas13 closed 1 month ago
Please rebase this on onto the ASAN PR from me or wait until it is merged: #2313 Just so we get extra test coverage.
There is one problem in test_arm_regression
. Is it expected?
I've updated python bindings and review is appreciated.
please avoid breaking API
I'm closing PRs. We'll think about what can be done.
Remove
cs_malloc()
andcs_free()
.cs_disasm_iter()
is a tiny wrapper aroundcs_disasm(count=1)
.Your checklist for this pull request
Detailed description
API change unifies disassembly process. Before, there were two separate functions to disassemble one instruction at a time in a loop and many instructions into a dynamic buffer. Commit will introduce user allocatable buffer that can be used in both situations with one function.
Updating the use of
cs_disasm_iter()
is a little more complicated thancs_disasm()
:Must be changed to:
Updating the use of
cs_disasm()
is straightforward, just usecs_buffer_new(0)
to create a buffer and pass it tocs_disasm()
.Benchmarks
Test plan
Update bindings and user software.
Closing issues
...