test_tms320c64x.c does not abort when not enabled

capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.

http://www.capstone-engine.org

7.18k stars 1.52k forks source link

test_tms320c64x.c does not abort when not enabled #2383

Open cmcneish opened 4 weeks ago

cmcneish commented 4 weeks ago

Compare: https://github.com/capstone-engine/capstone/blob/1a6921f5cc3e1084a6658ad05ed2c00a7ff1fd00/tests/test_tms320c64x.c#L153 https://github.com/capstone-engine/capstone/blob/1a6921f5cc3e1084a6658ad05ed2c00a7ff1fd00/tests/test_arm.c#L290

This means that checking that abort() has been called in the test when tms320c64x isn't enabled will fail.

All other architecture-specific tests seem ok

Rot127 commented 4 weeks ago

I'll start to modernize the whole testing anyways. So this will be fixed with it.