Python2 leftovers v2 - Githubissues

capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.

http://www.capstone-engine.org

7.18k stars 1.52k forks source link

Python2 leftovers v2 #2395

Closed twizmwazin closed 3 days ago

twizmwazin commented 5 days ago

Your checklist for this pull request

[x] I've documented or updated the documentation of every API function and struct this PR changes.
[x] I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Rebases #2378 onto next, adds a commit updating shebangs to python3, I only found one.

...

Test plan

...

Closing issues

...

twizmwazin commented 5 days ago

I also noticed that there are some files in suite that are unported. Do we need to port those?

XVilka commented 5 days ago

Most of the suite files probably should be removed as they are deprecated in favor of auto-sync tools.

Rot127 commented 5 days ago

Most of the suite files probably should be removed as they are deprecated in favor of https://github.com/capstone-engine/capstone/issues/2015 tools.

Yes, but let's do this before v6 (not here). Because they are not used. But this code here is run in the CI. Cleaning up suite is more than just the Pythin 2 files.

Rot127 commented 5 days ago

@twizmwazin Any chance you find time to finish https://github.com/capstone-engine/capstone/pull/2369 on behalf of @pyrox0? It is the only one for v5.0.2