[PPC] Fix #2401 - incorrect operands in disassembled instructions

[valdaarhun]

Your checklist for this pull request

• [ ] I've documented or updated the documentation of every API function and struct this PR changes.
• [x] I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Disassembling the "slwi", "srwi" and "rldicr" PowerPC instructions with the "-d" option displays the wrong operands in detailed information. This is due to an incorrect break condition in PPC_insert_detail_op_imm_at()

Test plan

• Before applying the fix:

  $ cstool -d ppc32be 786226e4
  0  78 62 26 e4  sldi   r2, r3, 4
      ID: 868 (rldicr)
      Is alias: 2329 (sldi) with ALIAS operand set
      op_count: 3
              operands[0].type: REG = r2
              operands[0].access: WRITE
              operands[1].type: REG = r2
              operands[1].access: WRITE
              operands[2].type: IMM = 0x4
              operands[2].access: READ

• After applying the fix:

  $ cstool -d ppc32be 786226e4
  0  78 62 26 e4  sldi   r2, r3, 4
      ID: 868 (rldicr)
      Is alias: 2329 (sldi) with ALIAS operand set
      op_count: 3
              operands[0].type: REG = r2
              operands[0].access: WRITE
              operands[1].type: REG = r3
              operands[1].access: READ
              operands[2].type: IMM = 0x4
              operands[2].access: READ

Please let me know if this should be added in the testsuite too. I am not sure how one does that.

Closing issues

closes #2401

[Rot127]

Thanks a lot! I check it tomorrow. But you can add a test case in the issue.cs file. The one in <repo-root>/tests/cs_detail/. Just do it as the other tests there.

[valdaarhun]

Thanks a lot! I check it tomorrow. But you can add a test case in the issue.cs file. The one in <repo-root>/tests/cs_detail/. Just do it as the other tests there.

Hi, thank you for your reply. I have added three test cases to issue.cs.