Closed wargio closed 3 weeks ago
The auto-sync test is fixed in the modern_testing
PR.
diff --git a/suite/auto-sync/src/autosync/cpptranslator/patches/FieldFromInstr.py b/suite/auto-sync/src/autosync/cpptranslator/patches/FieldFromInstr.py
index 67f7faae..58092ea0 100644
--- a/suite/auto-sync/src/autosync/cpptranslator/patches/FieldFromInstr.py
+++ b/suite/auto-sync/src/autosync/cpptranslator/patches/FieldFromInstr.py
@@ -41,9 +41,9 @@ class FieldFromInstr(Patch):
# Determine width of instruction by the variable name.
if ffi_first_arg_text[-2:] == "32":
- inst_width = 4
+ inst_width = b"4"
elif ffi_first_arg_text[-2:] == "16":
- inst_width = 2
+ inst_width = b"2"
else:
# Get the Val/Inst parameter.
# Its type determines the instruction width.
diff --git a/.github/workflows/auto-sync.yml b/.github/workflows/auto-sync.yml
index 9d26470d..d1428d06 100644
--- a/.github/workflows/auto-sync.yml
+++ b/.github/workflows/auto-sync.yml
@@ -101,4 +101,3 @@ jobs:
./src/autosync/cpptranslator/Differ.py -a ARM --check_saved
./src/autosync/cpptranslator/Differ.py -a PPC --check_saved
./src/autosync/cpptranslator/Differ.py -a LoongArch --check_saved
- ./src/autosync/cpptranslator/Differ.py -a Mips --check_saved
@Rot127 fixed
@kabeor
Would be nice to get it merged, so Coverity would check this code too, also we could update it in Rizin @kabeor
Your checklist for this pull request
Detailed description Adds options for:
CS_OPT_SYNTAX_NOREGNAME
on MipsCS_OPT_SYNTAX_NO_DOLLAR
(new, removes$
from the register)Adds support for:
cstool has been refactored for better UX: now by adding
+<feature>
you can directly modify the output of capstone using all options.For example:
Also fixes the following issues:
Fix #1519
Fix #1743
Fix #1869
Fix #1990
Fix #1958
Fix #2448
Fix #1054
Fix #1133
Fix #1267
Fix #1508
Fix #1634
Fix #1673
Fix #1680
Fix #1780
Fix #1851
Fix #1957