search

capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.
http://www.capstone-engine.org
7.33k stars 1.54k forks source link

Typos in Python arm64 bindings #2411

Closed david942j closed 1 month ago

david942j commented 1 month ago

I noticed this typo when reviewing Python bindings code on the v5 branch.

class Arm64OpSmeIndex(ctypes.Structure):
    _fileds_ = (
        ('reg', ctypes.c_uint),
        ('base', ctypes.c_uint),
        ('disp', ctypes.c_int32),
    )

"fileds" should be "__fields"

Same typo exists (and gets more) on the next branch, in both class AArch64OpSme(ctypes.Structure) and class AArch64OpPred(ctypes.Structure)

Unsure what may be broken in the Python binding but I believe they should be fixed anyway. I am sending pull requests.

Rot127 commented 1 month ago

Thanks, bindings are not yet properly tested. But will be with https://github.com/capstone-engine/capstone/pull/2384