capstone-engine / capstone

Capstone disassembly/disassembler framework for ARM, ARM64 (ARMv8), Alpha, BPF, Ethereum VM, HPPA, LoongArch, M68K, M680X, Mips, MOS65XX, PPC, RISC-V(rv32G/rv64G), SH, Sparc, SystemZ, TMS320C64X, TriCore, Webassembly, XCore and X86.
http://www.capstone-engine.org
7.51k stars 1.54k forks source link

[next] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64... #2444

Closed Rot127 closed 1 month ago

Rot127 commented 1 month ago

Your checklist for this pull request

Detailed description

Fixes several issues:

Test plan

Only one attempted upload (failing job published): https://github.com/Rot127/capstone/actions

Lists correct wheels in: https://github.com/Rot127/capstone/actions/runs/10448404651

Closing issues

closes https://github.com/capstone-engine/capstone/issues/2449

doronz88 commented 1 month ago

I'm not sure but possibly needing to add merge-multiple: true to download-artifacts as described in #2449 as the latest arm64 remains broken with latest version

Rot127 commented 1 month ago

Ah ok, now I get what you mean. Let me quickly check the docs of gh-action-pypi-publish action again. This behavior seems weird to me.