search

capstone-rust / capstone-rs

high-level Capstone system bindings for Rust
217 stars 75 forks source link

Add RISC-V support #100

Closed Amanieu closed 3 years ago

Amanieu commented 3 years ago

The vendored capstone is updated to include https://github.com/aquynh/capstone/pull/1682.

Amanieu commented 3 years ago

CI failure seems to be unrelated, the same error happens on master.

tmfink commented 3 years ago

Thanks for the PR, this looks really great!

My only request is that you add some unit tests, which will increase confidence (especially when we make subsequent upgrades to the bundled capstone). I suggest convert several of the instructions from capstone-sys/capstone/tests/test_riscv.c.

As an example, take a look at capstone-rs/src/test.rs tests test_arch_mips()/test_arch_mips_detail().

Amanieu commented 3 years ago

I did add tests: https://github.com/capstone-rust/capstone-rs/pull/100/files#diff-a1c12c7efdc33c34fd3c1e0d29eec806c2444907eb898f64356208960fbae58f

tmfink commented 3 years ago

I did add tests: https://github.com/capstone-rust/capstone-rs/pull/100/files#diff-a1c12c7efdc33c34fd3c1e0d29eec806c2444907eb898f64356208960fbae58f

Sorry--don't know how I missed that. Thanks for the contribution!

Amanieu commented 3 years ago

Could you publish a new version with this change?

Amanieu commented 3 years ago

Ping for publishing a new release.

tmfink commented 3 years ago

I published version 0.9.0.