search

capstone-rust / capstone-rs

high-level Capstone system bindings for Rust
217 stars 75 forks source link

Bump bindgen version and add wasm support #101

Closed s1341 closed 3 years ago

s1341 commented 3 years ago

Bumped the bindgen version used (as packages with newer bindgen were conflicting).

Added WASM support, as without it I was running into issues with missing WASM related symbols.

tmfink commented 3 years ago

Thanks for the PR!

s1341 commented 3 years ago

Can you spin a version so that we can benefit from this change please?

tmfink commented 3 years ago

Can you spin a version so that we can benefit from this change please?

Before spinning another release, I want to merge #85 and perform some related clean-up (using slices instead of iterators).

Also, I think I need check the pre-generated bindings. On my computer, the bindings are changed slightly. @s1341 when you are building this crate, are you using the use_bindgen feature? Otherwise, I would not expect the bindgen feature bump to make a difference.

s1341 commented 3 years ago

yes. I'm using use_bindgen.

tmfink commented 3 years ago

@s1341 I spun a release for capstone-sys 0.14.0 and capstone 0.10.0

s1341 commented 3 years ago

Thanks!