search

capstone-rust / capstone-rs

high-level Capstone system bindings for Rust
213 stars 75 forks source link

make build reproducible for capstone_sys #152

Closed chenhdc closed 5 months ago

chenhdc commented 6 months ago

Hi, we found libcapstone_sys.rlib varies from filesystem readdir order. Probably from the read_dir in https://github.com/capstone-rust/capstone-rs/blob/7c9a51f6eb81709cde1de7f7498a0e16f29bd852/capstone-sys/build.rs#L74. fs::read_dir()'s behavior is platform-specific.
We found https://github.com/gyscos/zstd-rs/pull/162 resolves a similar issue in another lib. Please make build reproducible for capstone_sys.

tmfink commented 5 months ago

Fixed by #153

chenhdc commented 5 months ago

@tmfink when fix this issue， could publish a new release?

tmfink commented 5 months ago

@tmfink when fix this issue， could publish a new release?

capstone-sys v0.16.0 and capstone v0.12.0 were just published