search

capstone-rust / capstone-rs

high-level Capstone system bindings for Rust
220 stars 78 forks source link

X86OpMem methods are private #33

Closed m101 closed 6 years ago

m101 commented 6 years ago

Hi,

X86OpMem methods are private, these makes it impossible to access the different attributes.

Here is a patch private.txt

tmfink commented 6 years ago

Thank you for the report!

Next time, you can make a change in your own fork and file a Pull Request.

https://help.github.com/articles/creating-a-pull-request/

m101 commented 6 years ago

Thanks for the fast patch!

Oh right, ok I'll do that next time.

tmfink commented 6 years ago

Fixed with #34

AZWN commented 6 years ago

Would you mind creating a new version on crates.io? Currently the dependency is defined as below, but I do not really like to have a github revision as version:

capstone = { git = "https://github.com/capstone-rust/capstone-rs.git", rev = "dc10578aa27414afc93f0a87959b2f0c22dc66c3" }
tmfink commented 6 years ago

@AZWN The issue is that there are big changes coming with #35 that will affect all platforms. This will hopefully fix memory safety issues that have existed all this time.

tmfink commented 6 years ago

@AZWN release 0.4.0 is now available with many bug fixes, including this one.