refactor code consistency

capsule-corp-ternoa / ternoa-js

Ternoa JavaScript SDK to build on top of the Ternoa Chain ⚙️

https://docs.ternoa.network

Apache License 2.0

24 stars 11 forks source link

refactor code consistency #107

Closed ipapandinas closed 2 years ago

ipapandinas commented 2 years ago

Some cleaning have to be done to improve the code consistency:

[x] use BalanceType for BN on types
[x] rename index.test.ts into extrinsics.test.ts
[x] remove I from types names (e.g. INftState becomes NftStateType)
[x] rename all underscore cases into camel cases

Victor-Salomon commented 2 years ago

BN for in extrinsics' parameters will not be changed in the 1.4.0Alpha. Isn't it confusing fir end user to ask for a BalanceType ? expecting a BN can not be confusing for non used to BN users?

ipapandinas commented 2 years ago

IMO BalanceType is more confusing. BN stands for Big Number, it will be easy to get familiar with for non experimented users.

Moreover they are already a lot of documentation using BN (e.g. Working with numbers from the Polkadot API doc)

Polkadot API uses BN in its polkadot/utils packages.

Let's remove BalanceType type ✌️