capsule-corp-ternoa / ternoa-js

Ternoa JavaScript SDK to build on top of the Ternoa Chain ⚙️
https://docs.ternoa.network
Apache License 2.0
24 stars 11 forks source link

[IPFS upload Fix]: Use Buffer object for NodeJs environment #119

Closed nicolapertosa closed 2 years ago

nicolapertosa commented 2 years ago

Description

I could found a solution by using a Buffer object when we try to use "nftIpfsUpload" and "collectionIpfsUpload" utils in NodeJs.

What I do :

The "isBrowser" variable could rely on something else and can also be externalised in the helpers part. Of course, I'm still open to discuss which solution you prefer.

Related Issue

https://github.com/capsule-corp-ternoa/ternoa-js/discussions/111

Types of changes

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ternoa-js ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 0:03AM (UTC)
Victor-Salomon commented 2 years ago

@nicolapertosa 👋 Tested and validated ✅. Thanks again for you commitment into our SDK. We love your contribution! We switched your PR to the 1.4.0-alpha branch that will soon be released. This one is our next milestone 💎. Thanks 🚀

ipapandinas commented 2 years ago

thank you @nicolapertosa 🌟