Rent formatter utils - Githubissues

capsule-corp-ternoa / ternoa-js

Ternoa JavaScript SDK to build on top of the Ternoa Chain ⚙️

https://docs.ternoa.network

Apache License 2.0

24 stars 11 forks source link

Rent formatter utils #147

Closed ipapandinas closed 1 year ago

ipapandinas commented 1 year ago

Description

Rent formatter utils

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ternoa-js	✅ Ready (Inspect)	Visit Preview	Dec 19, 2022 at 3:55PM (UTC)

ipapandinas commented 1 year ago

BN arguments are not allowed anymore for rent's helpers. Maybe we can extend this idea to others FRAME pallets, what do you think @Victor-Salomon ?

validateTransformContractFee ensures amount formatting to send BN values to the chain, you can override it with your improvements @Victor-Salomon 😎

Victor-Salomon commented 1 year ago

@ipapandinas looks great. I will update the other validateTransformContractFee. Removing BN from our helpers/pallets might improve the DX and help us providing a smooth experience.