capt-jk / android-rcs-ims-stack

Automatically exported from code.google.com/p/android-rcs-ims-stack
0 stars 0 forks source link

Failure to send response to End User Confirmation request #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Receive ToS request
2. Accept it (notification area, click "Accept" button)
3. The client crashes internally but does not display any visual indication of 
the failure

What is the expected output? What do you see instead?

Expected: the response is sent to the server.

Actual: please see attached trace

What version of the product are you using? On what operating system?

Trunk, on Android 4.0.4

Please provide any additional information below.

Original issue reported on code.google.com by ngrigor...@gmail.com on 5 Jun 2012 at 5:38

Attachments:

GoogleCodeExporter commented 9 years ago
OK, it happens because the "End user confirmation URI" parameter is not set. I 
guess this has to be somehow made clear that in this situation the UAC cannot 
really handle the end user confirmation request...

Original comment by ngrigor...@gmail.com on 5 Jun 2012 at 5:52

GoogleCodeExporter commented 9 years ago

Yes it's because the URI parameter is not well provisionned
Nevretheless I think we should add a protection against this problem

Original comment by jmauffret@gmail.com on 5 Jun 2012 at 5:56

GoogleCodeExporter commented 9 years ago
Corrected in next release.
We just add a protection against empty string

private boolean sendSipMessage(String remote, ...) {
 if ((remote == null) || (remote.length() == 0)) {
    ...
    return false;
 }

Original comment by jmauffret@gmail.com on 7 Jun 2012 at 7:01