captain-amygdala / pistorm

68k Hardware Emulator
MIT License
737 stars 103 forks source link

Compile fails on Bullseye 64-bit #59

Closed Fastdruid closed 2 years ago

Fastdruid commented 2 years ago

Installed Raspberry PI OS Lite (64-bit) [Bullseye]. Followed instructions (all pre-req package installs performed).

make failed as per below:

pi@PiStorm:~ $ git clone https://github.com/captain-amygdala/pistorm.git
Cloning into 'pistorm'...
remote: Enumerating objects: 3954, done.
remote: Counting objects: 100% (2086/2086), done.
remote: Compressing objects: 100% (671/671), done.
remote: Total 3954 (delta 1489), reused 1911 (delta 1399), pack-reused 1868
Receiving objects: 100% (3954/3954), 10.61 MiB | 5.14 MiB/s, done.
Resolving deltas: 100% (2496/2496), done.
pispi@PiStorm:~ $ cd pistorm
pi@PiStorm:~/pistorm $ make PLATFORM=PI3_BULLSEYE
gcc -o  m68kmake  m68kmake.c
./m68kmake

        Musashi v4.60 68000, 68008, 68010, 68EC020, 68020, 68EC030, 68030, 68EC040, 68040 emulator
                Copyright Karl Stenerud (kstenerud@gmail.com)

Generated 1969 opcode handlers from 520 primitives
gcc -Wall -Wextra -pedantic -I. -I./raylib -I/opt/vc/include/ -march=armv8-a -mfloat-abi=hard -mfpu=neon-fp-armv8 -O3 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -lstdc++    -c -o emulator.o emulator.c
gcc: error: unrecognized command-line option ‘-mfloat-abi=hard’
gcc: error: unrecognized command-line option ‘-mfpu=neon-fp-armv8’
make: *** [<builtin>: emulator.o] Error 1
pi@PiStorm:~/pistorm $ uname -a
Linux PiStorm 5.15.32-v8+ #1538 SMP PREEMPT Thu Mar 31 19:40:39 BST 2022 aarch64 GNU/Linux

Repeated using Raspberry PI OS Lite (32-bit) [Bullseye], this compiled cleanly.

Suggest update the readme to use Raspberry PI OS Lite (32-bit) version only.

adam-ainsworth commented 2 years ago

I got this issue too on 64bit. A touch annoying having to start from scratch.

Calab commented 2 years ago

Ditto for me... Started with 64bit and had to start over.

FYI... I really appreciate the hard work that went into this project!

LemaruX commented 2 years ago

This isn't really a bug, as you have to run the 32bit version of PiOS.

I guess the readme needs updating to better highlight this.

Fastdruid commented 2 years ago

This isn't really a bug, as you have to run the 32bit version of PiOS.

I guess the readme needs updating to better highlight this.

It's a bug in the documentation as nowhere does it say "you have to run the 32bit version of PiOS".

I, like many others will pick the OS appropriate to the type of CPU. 64bit CPU = 64bit OS unless there is good reason not to. The 64-bit version has performance improvements over the 32-bit version.

So if the documentation doesn't explicitly say "use the 32-bit version" (and it doesn't) then people will run into this bug that isn't a bug. Hence raising it as an issue to change the documentation to specify 32-bit!

LairdBiil commented 2 years ago

Ok take a chill it was not on purpose.

On Thu, 18 Aug 2022 at 12:37, Fastdruid @.***> wrote:

This isn't really a bug, as you have to run the 32bit version of PiOS.

I guess the readme needs updating to better highlight this.

It's a bug in the documentation as nowhere does it say "you have to run the 32bit version of PiOS".

I, like many others will pick the OS appropriate to the type of CPU. 64bit CPU = 64bit OS unless there is good reason not to. The 64-bit version has performance improvements over the 32-bit version.

So if the documentation doesn't explicitly say "use the 32-bit version" (and it doesn't) then people will run into this bug that isn't a bug. Hence raising it as an issue to change the documentation to specify 32-bit!

— Reply to this email directly, view it on GitHub https://github.com/captain-amygdala/pistorm/issues/59#issuecomment-1219386550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQA4Z65VO2SRQCWHLGPJ7ODVZYN6HANCNFSM53SZAQGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Cheers Bill (MM3RTH)

LemaruX commented 2 years ago

Added a note to use Pi OS 32 bit

Pull request #60

captain-amygdala commented 2 years ago

Closing, thanks @LemaruX for updating the readme. Pull request merged