Add search box - Githubissues

captainbrosset / domprofiler

Firefox DevTools extension that records DOM mutations and events on a page

MIT License

35 stars 4 forks source link

Add search box #12

Closed nt1m closed 10 years ago

nt1m commented 10 years ago

This adds a basic search box functionality.

captainbrosset commented 10 years ago

This new search box looks great! Very useful. Thanks. Can you rebase your branch on top of my latest master though? Also, not a big deal for now, but it'd be great if you could squash all your PR commits into 1 final commit before opening the PR. Thanks Tim!

nt1m commented 10 years ago

I haven't learned to use the command line tool (Git) yet, so I'm just using the Web Interface.

captainbrosset commented 10 years ago

Oh ok, no problem then! It's also something I can do on my side before merging in your changes. If you're interested (and you should be) then this seems to explain it well: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

nt1m commented 10 years ago

@captainbrosset I did open another pull request ( #17 ) though. Thanks, I'll check the link.