captainepoch / husky

The most famous Pleroma client for Android.
https://husky.adol.pw
GNU General Public License v3.0
29 stars 0 forks source link

Reply notifications to post from Mitra account not appearing #96

Closed watamelonman closed 1 week ago

watamelonman commented 3 weeks ago

General description of the issue

Reply notifications to posts made by my account on Mitra appear blank in Husky, unlike those made to posts I'm tagged in which appear normally.

Screenshot_20240819-105631 Screenshot_20240819-105731

Husky information

If you think it is an instance-related issue, please specify the instance.

Steps to reproduce it

Please, describe the steps to reproduce the issue:

  1. Make post from Mitra account
  2. Get reply to that post
  3. Check notifications for blank notif

Where did you get Husky from:

silverpill commented 3 weeks ago

I think it happens because Mitra uses different notification types for replies (reply) and mentions (mention). Mastodon and Pleroma simply generate mention notification when someone is replying to your post.

Having a separate notification type for replies is useful, so I need to come up with a solution that will work for both Mitra-FE and other clients like Husky. Perhaps generate both notifications? Husky will ignore reply, and Mitra-FE can hide mention if reply is present.

silverpill commented 2 weeks ago

In Mitra 3.3.0 replies generate a mention notification instead of reply (for Mitra-FE, there's a new property subtype with value reply). That should fix the problem reported by @watamelonman

captainepoch commented 2 weeks ago

So... Can I close this issue then, @silverpill ?

silverpill commented 2 weeks ago

Yes, I think it can be closed.

@watamelonman could you confirm that fix is working?

watamelonman commented 1 week ago

Yes, I think it can be closed.

@watamelonman could you confirm that fix is working?

Can confirm it's fixed

captainepoch commented 1 week ago

I'll close the issue then. Thank you!