search

captainhookphp / plugin-composer

A composer-Plugin to easily use CaptainHook
MIT License
19 stars 4 forks source link

Reduce console output #5

Open aleksblendwerk opened 4 years ago

aleksblendwerk commented 4 years ago

ARRRR! Using this plugin, the Cap'n is a bit too talkative for me - it would be nice to have a way to not hear anything from him (including the CaptainHook Composer Plugin line) or only hear from him when something has actually been done within a call of composer update or install.

It's probably just one of my weird OCD symptoms but I would prefer if there is no output when it just reports that all of the hooks are already installed - it just weirds me out a bit having so much additional output after an ordinary composer update.

Maybe this could be done by setting an option in the extra section of composer.json with a few different values, among them one that will never output anything and one that will only output stuff when there have actually been any changes to the actual hooks.

sebastianfeldmann commented 4 years ago

Sounds doable, I'll have a look at it

sebastianfeldmann commented 4 years ago

The captainhook install command does currently not abide to the captainhook.json verbosity setting.

Would it be suffice for you if that would be the case so you could configure verbosity there?

This is my composer update output after fixing it locally and setting the Captains verbosity to quiet ?

$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 0 updates, 0 removals
Generating autoload files
5 packages you are using are looking for funding.
Use the composer fund command to find out more!
CaptainHook Composer Plugin
  Using CaptainHook config: /Users/sf/Development/github.com/captainhook/captain-install plugin/captainhook.json
aleksblendwerk commented 4 years ago

If it's up to me I'd rather have no output at all when the plugin calls the install command and no changes are done to the hook files.

If I am getting this right if I set the verbosity setting in the config to quiet, the actual hook actions don't output anything any more either and just silently fail. That's not what I'd want it to do.

Sorry for being such a pain... :)

Maybe the verbosity of the plugin should be configurable in the extra section of composer.json instead, same as the already existing plugin options?

sebastianfeldmann commented 4 years ago

No pain at all, I totally get it. I will think about it a bit more and see what I can come up with.