search

captainyarr / popcorntime-ce-desktop

official desktop repository of original popcorn time community edition
Other
21 stars 2 forks source link

Adding ARM Support #28

Open AndrejaN opened 6 years ago

AndrejaN commented 6 years ago

Hi everyone,

This is not an issue, but I don’t know how to send a message to the captainyarr privately. I would like if it is possible to add ARM support for the current and future codes directly. So I’m using this fork for long time, very happy, and I have built a PTC with ARM support for my Raspbery Pi3, where I’m running Serviio 1.9.2 just for any case if the Samsung TV doesn’t want to start the movie. Also, Serviio has great support for subtitles download. And thanks for the Download Only option!! Here is what I’m doing.

  1. Download the code and run npm install on Windows using GitBash.

  2. After that, I copy the 3 files attached in the 1.zip file into ..\node_modules\nw-builder\lib to overwrite the 3 files, to add ARM support.

  3. I download the ARM nw.js files from https://github.com/LeonardLaszlo/nw.js-armv7-binaries/releases (nwjs-sdk-v0.27.6-linux-arm-chrome-branding.tar.gz)

  4. I copy them into file cache\0.31.2-sdk\linuxarm

  5. I run in GitBash gulp build -p linuxarm

  6. Then I zip them and transfer to RaspberyPi3, and running.Done!

Could you change gulpfile.js also:

So, my request to captainyarr is: Is it possible this to be automate in same way so I don’t need to go all these steps every time the code changes?

captainyarr commented 6 years ago

Thanks for creating this post! I think its really great idea to help getting it running on the Pi3. It would be great to get everything integrated into my main branch as well.

I just pushed a commit that updated the gulpfile to support your "linuxarm" build.

gulp build -p linuxarm will have the following settings:

An enhancement to this would be specifying it in the command line. Let me know if this helps!

Feel free to submit a pull request if more changes are needed.

AndrejaN commented 6 years ago

Hi Captainyarr,

i have small comments on the gulpfile.js code:

Lines 20 - 22 are not needed. Line 25 should be: buildDownloadUrl = 'https://github.com/LeonardLaszlo/nw.js-armv7-binaries/releases/download/v0.27.6/nwjs-sdk-v0.27.6-linux-arm-chrome-branding.tar.gz';

Also, Line 14 can be: var nwVersion = '0.31.2'; and Line 15 can be buildDownloadUrl = 'https://dl.nwjs.io/';. They both work fine, i have tried. Win32,64,Linux32,64,Osx32,64 can benefit from running higher nw.js binaries. But, this is up to you, if you want to stick with 0.20.1 is fine, for me 0.31.2 runs faster.

And finally, i wrote to https://github.com/nwjs-community/nw-builder/issues/494 admin, to add ARM support on the nw-builder package, so we don't need to copy them after npm install command. I hope they will add ARM support to their future package release.

Thanks

captainyarr commented 6 years ago

@AndrejaN

Ok made the change requested in your comment to the downloadUrl.

If you need additional changes feel free send a pull request.

I will look into updating to 0.31.2, but the normal version will break the internal PopcornTime viewer unless we update the binary dll. Definitely worth looking into.