captbaritone / grats

Implementation-First GraphQL for TypeScript
https://grats.capt.dev
MIT License
308 stars 16 forks source link

VSCode plugin not working with TS 5.5.2 #142

Closed sikanhe closed 4 months ago

sikanhe commented 4 months ago

Grats CLI is working but getting errors with the editor plugin

Unexpected Grats tag in detached docblock. Grats was unable to determine which TypeScript declaration this docblock is associated with. Moving the docblock to a position with is unambiguously "above" the relevant declaration may help. For more information see: https://grats.capt.dev/docs/getting-started/comment-syntaxGrats(1038)
image
captbaritone commented 4 months ago

Note to self: this is likely related to https://github.com/microsoft/TypeScript/pull/55739

captbaritone commented 4 months ago

Hmm, I'm unable to reproduce this. I've tried to create a repro here: https://github.com/captbaritone/grats-issue-142-repro. That project uses TypeScript 5.5.2 and the plugin still seems to be working fine.

captbaritone commented 4 months ago

Update, I was able to trigger the issue in my repo by making this change: https://github.com/captbaritone/grats-issue-142-repro/commit/1f3c4363b711b4a5951fec9adbcf10a1ab8acf8f