Closed hyperh closed 6 years ago
Hmm seems like the library doesn't like console
Merging #54 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #54 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 24 29 +5
Branches 9 11 +2
=====================================
+ Hits 24 29 +5
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cf087c7...3cbe762. Read the comment docs.
I think we're conflating multiple things. I suppose the core issues here are:
raven-for-redux
is not compatible with the Node version of ravenraven-for-redux
expects to only be called once.
I would rather check for these two things explicitly.
Can we think of a way to check if the Raven
object we get is raven-node
, and if we detect it, warn the user about the incompatibility?
As you initially did, can we set a flag when we first run, and warn about the memory leak if we get called a second time?
… multiple times
Resolves #51