search

captbaritone / raven-for-redux

A Raven middleware for Redux
295 stars 25 forks source link

Defer running the state and action transforms #8

Closed captbaritone closed 7 years ago

captbaritone commented 7 years ago

Fixes #6.

codecov-io commented 7 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          16     20    +4     
  Branches        5      6    +1     
=====================================
+ Hits           16     20    +4
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 181d2bc...04cad54. Read the comment docs.

ChrisSargent commented 7 years ago

All looks good to me - tested in my dev and the function is only called when submitting the error and the error is going through with the modified state so all looks good to me.

captbaritone commented 7 years ago

I will add some additional documentation to clarify how this works with user defined data callbacks and then cut a new release.

captbaritone commented 7 years ago

Thanks for prompting me to look into this again, and thanks for reviewing. 👏

ChrisSargent commented 7 years ago

No worries, thanks for the promptness!

captbaritone commented 7 years ago

Version 0.6.0 has been published.