captbaritone / raven-for-redux

A Raven middleware for Redux
295 stars 25 forks source link

Add breadcrumbMessageFromAction option to handle a message of breadcrumb #98

Closed xnimorz closed 6 years ago

xnimorz commented 6 years ago

Hello @captbaritone !

Sometimes it's necessary to use the different message of action breadcrumb instead of action.type. In my project I implemented it, using Raven.dataCallback option. But I have to filter if the breadcrumb is action. It would be great if raven-for-redux have this feature. So I added breadcrumbMessageFromAction that allows defining a function to change a message of action. It could be very useful if we want to handle in Sentry custom actions.

codecov-io commented 6 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #98   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          26     28    +2     
  Branches       10     11    +1     
=====================================
+ Hits           26     28    +2
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ab4e52...7ee6daf. Read the comment docs.

captbaritone commented 6 years ago

Great idea! A few wording note, but otherwise looks good. If you can make those few changes, I can cut a release later today.

xnimorz commented 6 years ago

@captbaritone thank you for the review! I added fixes in the separated commit 7ee6daf

captbaritone commented 6 years ago

Thanks! I’ll reply here when I cut the release.

captbaritone commented 6 years ago

Just cut 1.4.0 https://github.com/captbaritone/raven-for-redux/commit/fbe0f54355701a261362838d11f27bc155097b88 which includes this feature. Thanks again for the pull request.