search

captbaritone / urlmeme

A meme generator where the URL is the user interface
http://urlme.me
MIT License
123 stars 18 forks source link

Escaped "/"s in url are not handled correctly #3

Open captbaritone opened 9 years ago

captbaritone commented 9 years ago

It looks like Flask hands them to me already escaped, so I can't tell the difference...

hanndull commented 5 years ago

If flask hands it over to the program already escaped, how does the program prompt the translucent "error" layer that gets added over the top of the meme?

Screen Shot 2019-04-01 at 11 26 28 AM

hanndull commented 5 years ago

(also, this is Hannah)

captbaritone commented 5 years ago

Hey! The overlay is actually a loading overlay. I think what’s happening is we are getting an error (404?) back from the server because the url does not match any of the declared routes. Then, the front end code never handles the error case. So, it goes into the loading state, and starts waiting for the successful loading of the image. But, since the image fails to load, we never get the event that tells us that the image loaded, and we (the front end code) gets stuck.

That’s all on the front end (JavaScript). I’m not sure why the Flask server errors when you type in that url. If you can get the app running locally (pip install can be a real pain to get setup) then you might see a helpful error in the cli when you try to load that image with the extra slashes.

captbaritone commented 5 years ago

I’ve filed a separate issue for the error handling on the front end: https://github.com/captbaritone/urlmeme/issues/30