search

captbaritone / webamp

Winamp 2 reimplemented for the browser
https://webamp.org
MIT License
10.01k stars 662 forks source link

Turn 'status' CSS class into 'webamp-status' #1116

Closed TheStranjer closed 3 years ago

TheStranjer commented 3 years ago

This is my first attempt at replacing the status CSS class of the <div> within main-window to webamp-status. It appears to work, and it certainly fixed the problem for me when I uploaded my local build onto my site, but this naturally merits some code review.

Background For Those Unaware: There was a weird bug I encountered when I tried to run a copy of this with soapbox-fe, written by @alexgleason, which precluded me from dragging the main window around on the page. This addresses that... and, hopefully, breaks nothing else.

captbaritone commented 3 years ago

I think there's one more place to catch: https://github.com/captbaritone/webamp/blob/master/packages/webamp/js/components/Skin.tsx#L113

TheStranjer commented 3 years ago

Pushed @captbaritone

captbaritone commented 3 years ago

Thanks! I'll cut a release tonight or tomorrow.