search

captbaritone / webamp

Winamp 2 reimplemented for the browser
https://webamp.org
MIT License
9.72k stars 642 forks source link

TrueTypeFont, Simple PlaylistEditor, scrollbars. #1169

Closed x2nie closed 2 years ago

x2nie commented 2 years ago

First shown: Playlist & Scrollbars pledit-scrollbar

Bugfix implementation of XuiElement (not yet completed) such as ButtonLed, FadeButton. image

Show time in 2 mode: Remaining & Elapsed (changed by click) image

captbaritone commented 2 years ago

Sorry I haven't had time to review this properly, it's a big change and I've been busy with some other life stuff going on. I'll try to get back to this as soon as I can.

x2nie commented 2 years ago

Hi @captbaritone , its okay if you are busy. Yeah, it is a big change, but there is already another bigger change I made in my another branch. I wouldn't make another PR until we proof that this one is okay. and as usual, let me know if some code is worst, later when you have time.

captbaritone commented 2 years ago

I've been too busy to make time for review. You're code overall has been great, and I don't want to hold you back. So I think my plan will be to just default to merging your PRs right away from now on. If there are parts of the code that you have questions about or want particular feedback on, let me know and I can try to make time to look at those.

Thanks for all your work and your patience!