search

captbaritone / webamp

Winamp 2 reimplemented for the browser
https://webamp.org
MIT License
9.72k stars 641 forks source link

Equalizer Window: ON Button has the wrong dimension (2 pixels too wide) #1190

Open dettus opened 1 year ago

dettus commented 1 year ago

Hello!

So, I took the liberty of uploading this theme the other day...

https://skins.webamp.org/skin/75a086cef75b26371b184d28b9150860/d11amp059_theme.wsz/

Here, you will notice that the ON button is active, but at least one pixel of the AUTO button is illuminated as well. So, at first, I suspected the theme to have a bug, but when I loaded this theme

https://skins.webamp.org/skin/47597ab8e5ffcd39686d455c10c3b436/Garfield.zip/

I saw the same effect of the ON button bleeding over into the AUTO button. (Albeit only being visible with the pressed Button) I have not yet checked it against XMMS or WinAmp yet. Sorry.

0x5066 commented 1 year ago

Confirmed, WACUP and Winamp 5.666 both display the skin correctly, whereas Webamp does not. winamp original_g5SYNoK731

Interestingly enough I already took care of rendering it properly myself in my own classic skin framework, without even knowing. :p winamp original_Rwkx6HTeFq

dettus commented 1 year ago

AAAAND apparently your classic skin framework has a bug as well... The numbers are not the ones from the skin ;)

0x5066 commented 1 year ago

Modern Skin issue, honestly :) Can't reuse the numbers.bmp properly, and there's some other caveats as well.