search

captbaritone / webamp

Winamp 2 reimplemented for the browser
https://webamp.org
MIT License
10.11k stars 673 forks source link

AVS (primitive) & complete VIS modes #1208

Closed x2nie closed 1 year ago

x2nie commented 1 year ago

This patch is completing oscilloscope mode. additionally it provide a pixel perfect drawing (not blurred), with 576 sample wide (as most identical to winamp's vis visually), etc.

This also introduce AVS (maybe not complete yet, missing feature: next/prev? show current music title is not yet.) image

image

image

netlify[bot] commented 1 year ago

Deploy Preview for vigorous-lalande-5190c2 canceled.

Name Link
Latest commit 7e060633214ced97a2a5614f443723928d15f5f5
Latest deploy log https://app.netlify.com/sites/vigorous-lalande-5190c2/deploys/6419207a97b71c0008bf9c85
captbaritone commented 1 year ago

I'm a bit worried about adding all these binary files. With git, every time someone wants to clone the repo, they are going to need to download all of these files.

Is it necessary to have all of these assets in the repo? Also, this PR is too big to review. I'm happy to merge it on good faith if we can find a way to avoid having so many asset files (especially binary asset files).

x2nie commented 1 year ago

oh! good idea. I actually removed some of that binaries, in my another working branch. So, I think I will scrap this patch, and create another PR in another day.