captbaritone / webamp

Winamp 2 reimplemented for the browser
https://webamp.org
MIT License
10.25k stars 694 forks source link

TypeError: Cannot read property 'launchSongTitleAnim' of undefined #731

Open captbaritone opened 5 years ago

captbaritone commented 5 years ago

https://sentry.io/organizations/webamp/issues/897314194/?project=146021&referrer=github_plugin

TypeError: Cannot read property 'launchSongTitleAnim' of undefined
  at componentDidUpdate (../js/components/MilkdropWindow/Milkdrop.js:77:23)
  at Oi (../node_modules/react-dom/cjs/react-dom.production.min.js:247:171)
  at Ki (../node_modules/react-dom/cjs/react-dom.production.min.js:238:233)
  at Li (../node_modules/react-dom/cjs/react-dom.production.min.js:237:143)
  at Ri (../node_modules/react-dom/cjs/react-dom.production.min.js:250:118)
...
(2 additional frame(s) were not displayed)
captbaritone commented 5 years ago

Very strange bug that we keep seeing where somehow visualizer is not defined during a prop change.

captbaritone commented 5 years ago

FYI @jberg I've added some debug stuff to try to decipher what the hell is going on here.

jberg commented 5 years ago

Good call! Let me know if I can help debug if we see something. Guess its the same as the undefined render? Bizarre!