search

captivationsoftware / react-sticky

<Sticky /> component for awesome React apps
MIT License
2.64k stars 386 forks source link

let build fail when tests fails #264

Closed zerubeus closed 5 years ago

zerubeus commented 5 years ago

@vcarl this PR is never going to be merged ?

vcarl commented 5 years ago

I've been very busy at work and other projects, and don't really use this library much so it's not top of mind. I see some build errors in Travis, so I wanted to look into those before merging. Clearly it's been a little while though.

ignatiusreza commented 5 years ago

hi guys, I managed to fix travis build in #274!

regarding test failure, i think it would be best to configure travis to work with github checks, so that we can see each PR build status in github..

ref: https://blog.travis-ci.com/2018-05-07-announcing-support-for-github-checks-api-on-travis-ci-com

vcarl commented 5 years ago

Agreed, but I'm not a repo owner (just a random guy volunteering 😄) so I don't have access to settings.

ignatiusreza commented 5 years ago

Yeah.. can't we get hold of the repo owner or gain access somehow? Would be great to have it setup.. i'll be glad to help in anyway i can..

vcarl commented 5 years ago

I pushed a branch with a failing test and the build correctly failed, so I'm going to close this PR. Looks like updating deps fixed this issue as well.