Upgrade to dask-ms 0.2.3

caracal-pipeline / crystalball

Distributed prediction of visibilities from a sky model

GNU General Public License v2.0

2 stars 5 forks source link

Upgrade to dask-ms 0.2.3 #34

Closed sjperkins closed 4 years ago

sjperkins commented 4 years ago

[x] Tests added / passed
```
$ py.test --flake8 -v -s .
```
If the flake8 tests fail, the quickest way to correct this is to run autopep8 and then flake8 to fix the remaining issues.
```
$ pip install -U autopep8 flake8
$ autopep8 -r -i .
$ flake8 .
```

sjperkins commented 4 years ago

Upgrade to dask-ms 0.2.3 to take advantage of https://github.com/ska-sa/dask-ms/pull/75

sjperkins commented 4 years ago

@paoloserra @SpheMakh Would someone with write access to the repository please review this PR? It solves the OutOfMemory issues.

@PeterKamphuis tested this branch out in https://github.com/ska-sa/meerkathi/issues/723#issuecomment-567431537

KshitijT commented 4 years ago

@paoloserra @SpheMakh Would someone with write access to the repository please review this PR? It solves the OutOfMemory issues.

@PeterKamphuis tested this branch out in ska-sa/meerkathi#723 (comment)

Seconded, right now we need to install this branch separately and run crystalball out of the pipeline and then resume it again, which is all very cumbersome.

gigjozsa commented 4 years ago

@paoloserra @SpheMakh Would someone with write access to the repository please review this PR? It solves the OutOfMemory issues. @PeterKamphuis tested this branch out in ska-sa/meerkathi#723 (comment)

Seconded, right now we need to install this branch separately and run crystalball out of the pipeline and then resume it again, which is all very cumbersome.

Thirded...

PeterKamphuis commented 4 years ago

@paoloserra @SpheMakh Would someone with write access to the repository please review this PR? It solves the OutOfMemory issues. @PeterKamphuis tested this branch out in ska-sa/meerkathi#723 (comment)

Seconded, right now we need to install this branch separately and run crystalball out of the pipeline and then resume it again, which is all very cumbersome.

Thirded...

Fourthed

gigjozsa commented 4 years ago

@paoloserra needs to create a release to make it usable for Stimela/MeerKATHI.

gigjozsa commented 4 years ago

@SpheMakh can do this as well.

gigjozsa commented 4 years ago

@SpheMakh did so just now. @Athanaseus can now include this in Stimela.