caracal-pipeline / cult-cargo

Curated Stimela2 cargo for popular radio astronomy software
MIT License
0 stars 1 forks source link

minor param update #5

Closed Athanaseus closed 9 months ago

Athanaseus commented 9 months ago

Access tricolour's config file from parent when linked

Athanaseus commented 9 months ago

If this param is left out, I get:

───────────────────────────────────────────────────────────────────────────────── loop-pointings.mgpls-reductions.flag-rfi-0 ──────────────────────────────────────────────────────────────────────────────────
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO: ### validated inputs
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO: cab tricolour:
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO:   config = mgpls-illuminati/mgpls/ancillary/gorbachev.yml
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO:   flagging-strategy = standard
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO:   data-column = DATA
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO:   disable-post-mortem = True
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO:   ms = msdir/T16R02C02-corr-scan3-chan512-t16-XXYY.ms
2024-02-06 12:43:39 STIMELA.loop-pointings.mgpls-reductions.flag-rfi-0 INFO: singularity image SINGULARITY_IMAGES/quay.io-stimela2-tricolour:cc0.0.2.simg exists
### running /usr/bin/srun -J flag-rfi-0.mgpls-reductions.loop-pointings --time 1-12 --mem 100GB --cpus-per-task 4 /opt/tools/singularity-3.9.9//bin/singularity exec --containall --pwd /mnt/beegfs/mktplus    
--bind /mnt/beegfs/mktplus:/mnt/beegfs/mktplus:rw SINGULARITY_IMAGES/quay.io-stimela2-tricolour:cc0.0.2.simg tricolour --config mgpls-illuminati/mgpls/ancillary/gorbachev.yml --flagging-strategy standard    
--data-column DATA --disable-post-mortem msdir/T16R02C02-corr-scan3-chan512-t16-XXYY.ms
⠏ 0:00:10 loop-pointings ⠏ 0/3 complete, 3 workers  0:00:39  .1# Traceback (most recent call last):                                                                                                            

.1#   File "/usr/local/bin/tricolour", line 8, in <module>
.1#     sys.exit(main())
.1#   File "/usr/local/lib/python3.8/dist-packages/tricolour/apps/tricolour/app.py", line 248, in main
.1#     args = create_parser().parse_args()
.1#   File "/usr/lib/python3.8/argparse.py", line 1780, in parse_args
.1#     args, argv = self.parse_known_args(args, namespace)
.1#   File "/usr/lib/python3.8/argparse.py", line 1812, in parse_known_args
.1#     namespace, args = self._parse_known_args(args, namespace)
.1#   File "/usr/lib/python3.8/argparse.py", line 2018, in _parse_known_args
.1#     start_index = consume_optional(start_index)
.1#   File "/usr/lib/python3.8/argparse.py", line 1958, in consume_optional
.1#     take_action(action, args, option_string)
.1#   File "/usr/lib/python3.8/argparse.py", line 1870, in take_action
.1#     argument_values = self._get_values(action, argument_strings)
.1#   File "/usr/lib/python3.8/argparse.py", line 2401, in _get_values
.1#     value = self._get_value(action, arg_string)
.1#   File "/usr/lib/python3.8/argparse.py", line 2434, in _get_value
.1#     result = type_func(arg_string)
.1#   File "/usr/local/lib/python3.8/dist-packages/tricolour/apps/tricolour/app.py", line 102, in load_config
.1#     with open(config_file) as cf:
.1# FileNotFoundError: [Errno 2] No such file or directory: 'mgpls-illuminati/mgpls/ancillary/gorbachev.yml'
⠴ 0:00:10 loop-pointings ⠴ 0/3 complete, 3 workers  0:00:39  .0# Traceback (most recent call last):  
o-smirnov commented 9 months ago

@Athanaseus try the issue-189-revisited branch. I think this resolves the problem. But you're going to need to mark the ms input as readwrite anyway, so keep the PR open for that...

Athanaseus commented 9 months ago

Thanks @o-smirnov, that worked.