caracal-pipeline / stimela

Stimela 2.0
GNU General Public License v2.0
5 stars 4 forks source link

aliases missing check for inputs/outputs confusion #349

Open o-smirnov opened 1 day ago

o-smirnov commented 1 day ago

Put this into my recipe by mistake:

  inputs:
    source-ms: 
      aliases: [prep.source-ms]
      default: msdir/1729634772_sdp_l0-Jupiter-corr.ms
    dir-out-base: 
      aliases: [prep.dir-out-base]
      default: msdir

Mistake, because prep.dir-out-base is an output. But instead of an error, I get

(stimela) oms@janis:~/projects/JoveS$ stimela doc jove-prepare.yml jove-prepare
2024-11-26 15:35:03 STIMELA INFO: starting                                                                                                                                       
2024-11-26 15:35:03 STIMELA INFO: loaded full configuration from cache                                                                                                           
2024-11-26 15:35:03 STIMELA INFO: saving config dependencies to ./stimela.config.deps                                                                                            
2024-11-26 15:35:03 STIMELA INFO: will load recipe/config file jove-prepare.yml                                                                                                  
2024-11-26 15:35:04 STIMELA INFO: loaded 6 cab definition(s) and 3 recipe(s)                                                                                                     
stimela doc jove-prepare.yml jove-prepare
└── Recipe: jove-prepare
    ├── Description:
    │   └── Gets timeranges and runs jove-prepare-loop                                                                                                                           
    ├── Required inputs:
    │   └── source-ms  MS  [default: msdir/1729634772_sdp_l0-Jupiter-corr.ms]
    ├── Optional inputs:
    │   └── dir-out-base  str  [default: msdir]
    ├── Required outputs:
    │   └── dir-out-base  Directory   
    ├── Obscure outputs: omitting 1
    └── Steps:
        └── get-ranges     
            prep           
(stimela) oms@janis:~/projects/JoveS$ 

While I'm fixing this -- note that aliases to multiple named file outputs should be allowed. The latter should be fixed along with #287.