carapace-sh / carapace

command argument completion generator for spf13/cobra
https://carapace.sh
Apache License 2.0
321 stars 8 forks source link

InvokedAction: clear distinction to Action #983

Closed rsteube closed 8 months ago

rsteube commented 8 months ago

Use private composition instead of embedding.

Originally InvokedAction was just a type alias of Action. Embedding was then used to avoid some lsp oddities.

Functions of Action can still be called on InvokedAction. While that does not pose an issue for a clear distinction and to enforce a consistent usage it should prevented.

related https://github.com/zaquestion/lab/pull/886