caravagnalab / CNAqc

CNAqc - Copy Number Alteration (CNA) Quality Check package
GNU General Public License v3.0
14 stars 8 forks source link

Enhancements to plot_segments function? #34

Closed sigven closed 1 month ago

sigven commented 4 months ago

Hi,

Thanks for a very nice package with lots of great functionality for copy-number processing and visualization. This is really missing from other packages. Great work! I have been playing a bit with data from our tumor samples, and want to share some thoughts on the visualization function plot_segments:

Happy to get your input on these matters:-)

kind regards, Sigve

caravagn commented 4 months ago

Hi @sigven, thanks for your comments:

caravagn commented 3 months ago

Hi @sigven still interested on this?

sigven commented 3 months ago

Hi @caravagn, yeah indeed! Sorry for not responding, I hope to get back to you shortly.

sigven commented 1 month ago

Hi @caravagn (cc @pdiakumis),

Truly sorry for the very late response and follow-up on this matter. We have been working hard to use your package inside PCGR, where we want to plot allele-specific copy number input from tumor samples for clinical interpretation. Notably, PCGR relies upon the Conda framework, and we have struggled to make CNAqc install and work in our production environment, particularly due to its multiple dependencies that are currently hosted in multiple GitHub repositories (meaning they are non-Condarized). Again, we think the plot is very elegant and the functionality is very good, and would be great to expand upon, but currently we are unable to make it work properly in our production environment.

kind regards, Sigve

caravagn commented 1 month ago

Hi @sigven this is more clear now; I would love to see it used in your tool. Maybe we can help with this, let me talk with the guys and see if we can consider improving dependencies (some might be not strictly required).

Could you please clarify in which form you would like the package to be installable? Is the problem that the package depends on too many other packages for your internal use?

@luca-dex I might need you help on this.

caravagn commented 1 month ago

@luca-dex Regarding dependencies I think that

pdiakumis commented 1 month ago

Hello Giulio, Thanks for getting back to us, but please don't spend time on refactoring your codebase for our needs. As Sigve mentioned, we are only interested in the CNA segment plotting functionality that comes with CNAqc (which we could probably handle with a custom ggplot2 + plotly solution if we wanted some interactivity). The way we handle dependencies in PCGR is via conda (https://docs.conda.io/en/latest/) which is a great tool for managing R/Py/Perl pkgs and other bioinformatics tools. R pkgs can be converted into conda pkgs fairly easily if they are on CRAN/Bioconductor. Things get a bit trickier if they're only on GitHub, especially if their dependencies are also GitHub-only. From CNAqc's DESCRIPTION I can see multiple caravagn/caravagnalab dependencies (which is perfectly fine, I do that a lot too!). But these would be required to be firstly tagged and released, and then condarised themselves. There are probably other dependencies in there that would also need to be condarised. This is an arduous process and frankly not worth the effort for one plot. We are currently handling the installation of CNAqc into our conda environments simply by using remotes::install_github("caravagnalab/CNAqc"). This adds an extra 15-20min to our GitHub Actions pipeline, but works fine on Linux (but not MacOS). It's okay for now, but we will be looking into replacing this at some point.

caravagn commented 1 month ago

Hi @pdiakumis, I see, thanks for clarifying, I can then close this.

Then maybe the best for you is to re-use our code from

Best,

Giulio