search

caravagnalab / revolver

REVOLVER - Repeated Evolution in Cancer
https://caravagnalab.github.io/revolver/
64 stars 25 forks source link

unused argument: cutoff.features_annotation #11

Closed luca-dex closed 6 years ago

luca-dex commented 6 years ago

In rev_analyzer.R there is a call to revolver_plt_group_trajectories that pass as argument cutoff.features_annotation which is not defined for this function.

Shouldn't it be cutoff.edges_annotation ?

https://github.com/caravagn/revolver/blob/master/R/rev_analyzer.R#L290

caravagn commented 6 years ago

Luca, can you run also revolver_plt_dendogram 4 lines above this bug? I think that's a typo as well.

caravagn commented 6 years ago

@ttriche/ @luca-dex you fixed this with your merge request is this correct?

luca-dex commented 6 years ago

yes, closed with #12