search

caravagnalab / revolver

REVOLVER - Repeated Evolution in Cancer
https://caravagnalab.github.io/revolver/
64 stars 25 forks source link

Crash due to clonEvol code with 1 sample #13

Closed caravagn closed 6 years ago

caravagn commented 6 years ago

Line 528 of lib_clonevol.R

if (nSamples == 1 && length(vv[[1]]) > 0){

attempts to call a function get.model.score(vv[[1]][[i]]) which needs to be restored or removed.

caravagn commented 6 years ago

Maybe this prevents to run the tool with 1 single biopsy at the moment

caravagn commented 6 years ago

I am almost done re-writing the code that we took from clonEvol. Once done I will totally remove any dependence from clonEvol which should make everything smoother.

luca-dex commented 6 years ago

Also in function infer.clonal.models there is a call to get.model.non.negative.ccf.prob which doesn't exist

caravagn commented 6 years ago

Thanks, all clonEvol calls will be dropped in the next commit for this issue.

caravagn commented 6 years ago

@luca-dex I should have removed the dependency from cloneEvol with the last 2 commits, in the branch remove_clonevol. I would like to merge that branch to master but they might be out of synch -- can you help me with this?

Thanks.

caravagn commented 6 years ago

"removed the dependency from cloneEvol" means I re-coded the bits of clonevol that I wanted. Once the merge goes fine and this branch becomes master (with the currents commits ahead, if any), I might totally remove file lib_clonevol and go through some old functions that are now obsolete.

luca-dex commented 6 years ago

Closed with #22