caravan-bitcoin / caravan

Caravan monorepo
https://caravanmultisig.com
MIT License
37 stars 32 forks source link

Fix hermit selection #127

Closed bucko13 closed 2 months ago

bucko13 commented 2 months ago

Fixes an issue where the hermit interaction couldn't be loaded up for signing and would crash the app.

I converted the component to typescript so that I could catch other potential weirdness as the data was getting passed around (I did).

I split this into to commits so that the actual fixes could be seen more clearly. Typescript conversion and interaction fix. This probably also fixes an issue where hermit would've gotten a bad psbt if there was a taproot output.

Another component "had to be" converted to ts. First commit (extension change) is 812df1b and second with actual refactor and bug fixes is 383ef41.

Screenshot 2024-09-06 at 3 44 23 PM
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 4c1b4e58d6d84c042852e2645ddd039cf8a08c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 7:27pm