caravan-bitcoin / caravan

Caravan monorepo
https://caravanmultisig.com
MIT License
37 stars 32 forks source link

fix(wallets): bundle internal dependencies with production bundle #151

Closed bucko13 closed 2 weeks ago

bucko13 commented 2 weeks ago

When attempting to use caravan/wallets in an external application to leverage the fix that went out with #147 I was finding that the older external dependency was being used.

There were two options I could come up with to resolve this. One was to pin the version for internal dependencies in the caravan/wallets package.json. This felt like it lost many of the benefits of working in a monorepo environment. The other was to bundle the internal dependency with the final production bundle. Since we bundle with tsup, we can use the noExternal config to take care of this.

Long term this feels like the cleaner pattern and we'll probably want to do this across the packages that we publish.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 6b39b23e3fe1873ab6176705f9691de9ab25a628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @caravan/wallets | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 7:08pm