caravan-bitcoin / caravan

Caravan monorepo
https://caravanmultisig.com
MIT License
32 stars 29 forks source link

fix: ensure safe handling of interaction.Messages to prevent `map is not a function` error #77

Closed MashyBasker closed 5 months ago

MashyBasker commented 5 months ago

The error message TypeError: interaction.messagesFor is not a function suggests that messagesFor is not a function which can be called on the interaction object. To fix this we call messagesFor on the result of invoking interaction as a function.

Output after the change

image

Fixes #72

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 0ebcf7a4c14f59e214e320e947192296f4f8176c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ❌ Failed (Inspect) Apr 27, 2024 8:51pm
bucko13 commented 5 months ago

Unless I'm missing something about how this fix was implemented, I believe the correct fix should look like this: https://github.com/caravan-bitcoin/caravan/pull/81