Closed mittalyashu closed 5 years ago
We do want to support more beautiful default options, but definitely not random 😝 Maybe close this issue, and create a new one? Or just update the titles and such.
@mittalyashu totally understood! We do want to create a bunch of beautiful default themes that set the font, background, and color-theme, padding etc so users can quickly choose one that works best for them. But we don't want it to be "random" per se (:
We do want to create a bunch of beautiful default themes, but we don't want it to be "random".
Got it.
Maybe close this issue, and create a new one? Or just update the titles and such.
Done.
@mfix22, I have changed the title of the issue, now can you re-open the issue.
I'm interest in taking on this issue, Just to make it clear is the scope adding a 'templates' drop down menu as well as creating default themes to add to the menu? Also I'm assuming there will some approval process on the default themes? Thanks!
Just to make it clear is the scope adding a 'templates' drop down menu as well as creating default themes to add to the menu?
Yes, a predefined theme should include all the settings which carbon currently provide and we should be able to override the theme with custom setting if we want.
Awesome, I would love to be assigned to this!
@Jaredk3nt feel free to open a WIP PR and I can give you feedback as you go! 🙂 I figured posting screenshots of the theme would be a good way to verify which themes we like before finalizing on the selection UI.
@jakedex and I can help out the theme menu
Making a bunch of examples here are a couple that I think are good starts. Feedback is appreciated! I looked through a bunch that people have posted places to get a feel for the kinds of themes people are already using and are doing well.
About how many defaults is a good number to start with, maybe 5? or more?
@Jaredk3nt Yeah 5 theme is a good start.
Maybe try adding the settings along with the image, so that we can try it and give feedback.
@mittalyashu Here are the links for each of them:
https://carbon.now.sh/?bg=rgba(229%2C229%2C229%2C1)&t=seti&wt=sharp&l=auto&ds=true&dsyoff=12px&dsblur=27px&wc=true&wa=true&pv=50px&ph=47px&ln=false&fm=Hack&fs=13.5px&lh=128%25&si=false&es=2x&wm=false&ts=false (which I now realize looks pretty similar to the default theme when you first get to the site, so it would probably just be a good idea to include the default as the first theme in the list)
also what if rather than a solid background colour, we could have a gradient?
Expected Behavior
While playing around with the settings, it is possible that we might end up creating something like this, which looks horrible.
That's why we need help.
Actual Behavior
Generate a beautiful random settings.