search

carbon-budget-explorer / cabe

Web application to explore carbon budgets
Apache License 2.0
1 stars 0 forks source link

Check whether PCC convergence year is standard on 2050. #113

Closed MarkMDekker closed 7 months ago

Peter9192 commented 7 months ago

It is not:

https://github.com/carbon-budget-explorer/cabe/blob/49c333dfa175dc9bdee0ad2f76badc2230f287b8/ws.py#L308 https://github.com/carbon-budget-explorer/cabe/blob/49c333dfa175dc9bdee0ad2f76badc2230f287b8/ws.py#L334 https://github.com/carbon-budget-explorer/cabe/blob/49c333dfa175dc9bdee0ad2f76badc2230f287b8/ws.py#L432 https://github.com/carbon-budget-explorer/cabe/blob/49c333dfa175dc9bdee0ad2f76badc2230f287b8/ws.py#L488

Peter9192 commented 7 months ago

If you want to change this, one thing you could do is add a global variable at the top of the file called DEFAULT_CONVERGENCE_YEAR and use that variable in the 4 places above (I think that's all of them). Then you can easily change it again later. The allcaps is a standard styling convention to signify that it's a global variable.