feat(CloudHeader): Allow a custom menu in CloudHeader

carbon-design-system / carbon-addons-cloud

[DEPRECATED] Carbon Design System add-on for IBM Cloud

http://cloud-styles.carbondesignsystem.com

Apache License 2.0

15 stars 23 forks source link

feat(CloudHeader): Allow a custom menu in CloudHeader #38

Closed ajdaniel closed 6 years ago

ajdaniel commented 6 years ago

Allow for a custom menu icon and menu render in the Cloud Header. This can allow products to add something that doesn’t fully conform with the existing design, such as a help menu.

Changelog

New

customMenuIcon and renderCustomMenu props for CloudHeader

Signed-off-by: Andrew J Daniel adaniel@uk.ibm.com

joshblack commented 6 years ago

Is this for a particular offering/portfolio @ajdaniel? Definitely am down for adding this in if this is helping someone out right now. Unfortunately the UX around this will need to be considered as well, as that is the primary purpose of this component. cc @chrisconnors-ibm if you have any thoughts as well.

ajdaniel commented 6 years ago

@joshblack yes we are using this component in production for a watson Saas product, Conversation.

chrisconnors-ibm commented 6 years ago

this will be addressed as part of the new header work, not to be fixed at this time.

ajdaniel commented 6 years ago

@chrisconnors-ibm do you know when that might be?

ajdaniel commented 6 years ago

@joshblack @chrisconnors-ibm is this PR going to be approved and merged?

joshblack commented 6 years ago

Hey @ajdaniel! 👋 I think the last action item for this was communicated in the slack thread that we have for #carbon-design-system (I think). The hope would be to have a meeting with the relevant parties to help move this along.

joshblack commented 6 years ago

Hi there! The React part of this project has moved on over to carbon-addons-cloud-react. Going to close this PR on this project for now, but feel free to re-open on the React-based project!