search

carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Watson IoT products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

[Repo] Refactor from styled-components to Sass #370

Open davidicus opened 5 years ago

davidicus commented 5 years ago

We have decided to move away from styled components and will be instead going back to Sass partials for styling components to better align with the Carbon base workflow.

Work is complete when:

Updated list of components still using styled-components as of v2.72.0

tay1orjones commented 5 years ago

Once the above PR is merged, we just need to refactor components away from styled-components and into sass. That PR has an example of one component being refactored.

tay1orjones commented 4 years ago

As part of this, we should keep an eye on Carbon's v11 work slated for October. They're considering css-in-js, scss modules, and some other approaches.

tay1orjones commented 4 years ago

Something interesting to highlight here that surfaced in #1366: Carbon uses type checking in a few spots, which break with styled components.

Carbon's logic looks for a type ModalFooter, but with styled components we provide StyledModalFooter, which fails the check.

sstone2423 commented 3 years ago

Down to mainly Table as most of the other existing components are deprecated and will be removed in the next version