Closed blechner closed 1 year ago
Name | Link |
---|---|
Latest commit | 9b73ede86b4e2b755677b5b778abbe582d0724e0 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/640f529208a30400078d07df |
Deploy Preview | https://deploy-preview-3750--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Closes #
Summary
Change List (commits, features, bugs, etc)
originHref
parameter to be added to the logout URLs in such a way that the current page's query parameters are not included. An easier solution would be to just removeoriginHref
for good, since MAS is no longer using it, but we cannot assume that other consumers of the component aren't using it, so it is better to keep it in order to not introduce breaking changes.surveyData
to avoid runtime errors if this property becomes null in subsequent component re-renders.Acceptance Test (how to verify the PR)
window.history.replaceState(undefined, 'XXXX', window.location.href + "?tab=x")
. Wait for the idle timeout dialog to pop up and notice that the countdown happens normally, i.e. should keep decreasing by 1s. No frozen countdown number is expected.Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.